search

maciejhirsz / ramhorns

Fast Mustache template engine implementation in pure Rust.
https://crates.io/crates/ramhorns
Mozilla Public License 2.0
293 stars 29 forks source link

fix fallout from rust-lang/rust#119820 #69

Closed lcnr closed 6 months ago

lcnr commented 6 months ago

See the added comment for background. This change is necessary to avoid breaking downstream users once https://github.com/rust-lang/rust/pull/119820 lands. While the exact impact is uncertain, we know https://github.com/grego/blades to be affected.

Please ask for clarification if you would like further information. It is likely desirable to remove the parameter S from Ramhorms::get, always requiring str. This would require a new major version however. I apologize for the inconvenience.

maciejhirsz commented 6 months ago

Thanks for bringing this up! I'll go ahead with your suggestion and just require &str, it seems more idiomatic and less hacky of a solution to me.

Ramhorns can use a 1.0 release since it's been quite stable for a long time.