Normalize phrase and password according to specification

maciejhirsz / tiny-bip39

A Rust implementation of BIP-0039

Apache License 2.0

65 stars 37 forks source link

Normalize phrase and password according to specification #12

Closed wigy-opensource-developer closed 4 years ago

wigy-opensource-developer commented 4 years ago

I have not pulled in too many test cases, because if these all pass and a few that I missed would not, that would clearly be an issue with the unicode-normalization crate.

wigy-opensource-developer commented 4 years ago

@maciejhirsz Do you have any feedback on this PR pro or contra?

maciejhirsz commented 4 years ago

Just looking at this, I think there is room to improve performance in few places, mostly you should be able to combine the phrase by joining char iterators without intermediate String allocations, but that's not critical. So overall LGTM.