search

maciejhirsz / tiny-bip39

A Rust implementation of BIP-0039
Apache License 2.0
65 stars 37 forks source link

Add proper WASM support feature flags and tests #33

Closed dingxiangfei2009 closed 3 years ago

dingxiangfei2009 commented 3 years ago

This PR will supersede #32 if preferred.

This PR proposes the following changes:

  1. Enable proper WASM flags in the dependencies
  2. Remove parking_lot feature flag from once_cell, as suggested by its author matklad. In summary, recent once_cell has adapted to better work with std mutexes. See the discussion here
  3. Adapt the tests to run with wasm-pack by conditionally using wasm-bindgen-test
maciejhirsz commented 3 years ago

Cheers! Would be great to expand CI to also run the tests on Wasm, but that can come later.

maciejhirsz commented 3 years ago

Published in 0.8.2.