maciejkula / spotlight

Deep recommender models using PyTorch.
MIT License
2.97k stars 421 forks source link

Error in BPR loss function #185

Open PeterZaidel opened 3 years ago

PeterZaidel commented 3 years ago

Hello! Thank you for your great work! In your realisation of bpr loss you use the following formula:

loss = (1.0 - torch.sigmoid(positive_predictions - negative_predictions)) .

In the original publication (bpr paper) the authors propose loss = log(sigmoid(positive - negative)) + regularisation. Is it okay?