GH-28: add support for multiple property injection

maciejwalkowiak / wiremock-spring-boot

WireMock Spring Boot drastically simplifies testing HTTP clients in Spring Boot & Junit 5 based integration tests.

MIT License

218 stars 13 forks source link

GH-28: add support for multiple property injection #29

Open rfelgent opened 6 months ago

rfelgent commented 6 months ago

hi @maciejwalkowiak ,

here is the pull request for https://github.com/maciejwalkowiak/wiremock-spring-boot/issues/28.

Please let me know what else I can do for this pull request to be accepted.

rfelgent commented 5 months ago

Hi @maciejwalkowiak ,

I added some hints about the multiple property injection feature. Please have look at the README.md. While updating the README.md, 2 questions came into my mind:

should we rename the attribute from property to properties (hard migration with breaking changes) or
should we add another attribute called properties and it can co-exists with property (soft migration, no breaking changes)

Greetings

PS: I am not used to work with forks. I created another PR for updating the README.md https://github.com/maciejwalkowiak/wiremock-spring-boot/pull/31/

maciejwalkowiak commented 5 months ago

Thanks @rfelgent! Thanks for updating readme, don't worry it is in another branch, i'll put it into main all together when we have this PR ready.

rfelgent commented 5 months ago

Hi @maciejwalkowiak ,

I renamed/refactored the attributes property and properties of ConfigureWireMock. Please have a look at https://github.com/maciejwalkowiak/wiremock-spring-boot/pull/32/files

rfelgent commented 5 months ago

Hi @maciejwalkowiak ,

please let me know what else I can do for this merge request.