search

maciejwalkowiak / wiremock-spring-boot

WireMock Spring Boot drastically simplifies testing HTTP clients in Spring Boot & Junit 5 based integration tests.
MIT License
218 stars 13 forks source link

`WireMock` naming collision #8

Closed maciejwalkowiak closed 1 year ago

maciejwalkowiak commented 1 year ago

There is a great likelihood that both com.maciejwalkowiak.wiremock.spring.WireMock and com.github.tomakehurst.wiremock.client.WireMock classes will be imported into a single file which forces user to use one of them with full qualified name.

For example:

@com.maciejwalkowiak.wiremock.spring.WireMock("user-service")
private WireMockServer wiremock;

To avoid breaking change, there should be a new annotation introduced that will behave exactly the same as com.maciejwalkowiak.wiremock.spring.WireMock just with a different name.

Ideas:

Suggestions for name very welcome!

SimonVerhoeven commented 1 year ago

@InjectWireMock carries my preferences since it also has the lowest likelihood of people incorrectly autocompleting, and then scratching their head.

gurukulkarni commented 1 year ago

Maybe @Wiremocked ?