search

maciekgrzybek / svelte-inview

A Svelte action that monitors an element enters or leaves the viewport.🔥
MIT License
749 stars 23 forks source link

Change scrollDirection check in animation example #30

Closed mindvoxel closed 1 year ago

mindvoxel commented 1 year ago

I think the scrollDirection check is supposed to be 'up' rather than 'top' because it looks like the Direction type can only be 'up', 'down', 'left', or 'right'

netlify[bot] commented 1 year ago

Deploy Preview for svelte-inview failed.

Name Link
Latest commit 7284c9c877badd60c00a2098092bdd168a4f971b
Latest deploy log https://app.netlify.com/sites/svelte-inview/deploys/63d2029dd80fbd0008990682
maciekgrzybek commented 1 year ago

Hey Chris, good spot :) I need to figure out the CI first, but I'll merge your PR afterwards :) thanks for the contribution :)

mindvoxel commented 1 year ago

@maciekgrzybek great! thanks!