search

maciekgrzybek / svelte-inview

A Svelte action that monitors an element enters or leaves the viewport.🔥
MIT License
749 stars 23 forks source link

"inview_change" doesn't work for after updating from 3.0.4 to 4.0.0 #42

Closed xGihyun closed 1 year ago

xGihyun commented 1 year ago

I tried updating the package to the latest version, and when I changed "on:change" to "on:inview_change", it stopped working. Changing back to "on:change" made this work normally (but there are a lot of type errors as expected). I tried to console.log() the handleChange() function that's used for "on:inview_change" but it seems like the function doesn't run at all. I just tried copying what was on the docs btw

maciekgrzybek commented 1 year ago

Hey @xGihyun can you show a reproduction? I'm testing it locally + e2e tests and it seems to be working fine

xGihyun commented 1 year ago

Never mind, somehow it works now? I didn't really do anything special, thanks for the response though, I will post an issue again if things don't go well again