Update facebook IDs format from numbers to strings.

maciekmm / messenger-platform-go-sdk

:envelope: A GO SDK for Facebook's messenger-platform: https://developers.facebook.com/docs/messenger-platform

MIT License

110 stars 27 forks source link

Update facebook IDs format from numbers to strings. #1

Closed marselester closed 8 years ago

marselester commented 8 years ago

Hi, thanks for the SDK!

According to https://developers.facebook.com/bugs/578746852290927/

We decided to switch our encoding to use strings instead of ints for user & page IDs

The PR handles the matter and doesn't brake existing interface. But I think it would be better to change type from int64 to string though.

coveralls commented 8 years ago

Coverage remained the same at 80.814% when pulling cba71015b1c4001a7756c8c7995fe4fd905f85de on marselester:master into aa21565ede764a443e67074deba7a013666bb2b2 on maciekmm:master.

maciekmm commented 8 years ago

Hello @marselester, thanks a lot for the pull request.

I will merge this into the new tag based on current implementation, change the type to string and publish it as a next release.

Have a great day