search

maciekmm / messenger-platform-go-sdk

:envelope: A GO SDK for Facebook's messenger-platform: https://developers.facebook.com/docs/messenger-platform
MIT License
110 stars 27 forks source link

Made attachments plural #5

Closed EwanValentine closed 8 years ago

EwanValentine commented 8 years ago

Feel free to delete this if I'm wrong, but the Facebook SDK suggests message attachments is attachments not attachment.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 80.814% when pulling ecbaebdd505d283026ac6e81c8a9148ba10637ae on EwanValentine:hotfix/made-attachments-plural into a8d293f1dd2f8f8943e688122f29d928bae29c6a on maciekmm:master.

maciekmm commented 8 years ago

Thanks for the contribution! It looks like sending a message permits only one attachment and receiving can have multiple. We may want to separate Message into two structs: one for receiving and one for sending.

Regards

EwanValentine commented 8 years ago

@maciekmm I've started in doing that on this same branch. I'm just testing it now, let me know if this isn't what you meant. Cheers!

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 80.814% when pulling 2b489db67304862e8e4ea861c1bb54eae6ef4aea on EwanValentine:hotfix/made-attachments-plural into a8d293f1dd2f8f8943e688122f29d928bae29c6a on maciekmm:master.

maciekmm commented 8 years ago

Hello @EwanValentine, Thanks for contribution. What is the purpose of ReceiveMessage struct? Can't it be merged to ReceivedMessage ?

EwanValentine commented 8 years ago

@maciekmm I wasn't too sure if ReceivedMessage was used for something else, elsewhere. If you're happy for me to merge those I can do :)

maciekmm commented 8 years ago

@EwanValentine --If you can, do it :)--

EDIT: Changed it on my own.

Thanks a lot for contribution!

EwanValentine commented 8 years ago

Apologies, was away from my laptop last night. Great work, thanks! :)