macisamuele / language-formatters-pre-commit-hooks

Collection of custom pre-commit hooks.
Apache License 2.0
115 stars 58 forks source link

Add --google-java-formatter-jar parameter #156

Closed fabasoad closed 1 year ago

fabasoad commented 1 year ago

Adding --google-java-formatter-jar parameter to have possibility to use pre-downloaded formatter.


Closes #119

codecov[bot] commented 1 year ago

Codecov Report

Merging #156 (1ebf251) into master (4bc272d) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #156   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          315       319    +4     
=========================================
+ Hits           315       319    +4     
Impacted Files Coverage Δ
..._formatters_pre_commit_hooks/pretty_format_java.py 100.00% <100.00%> (ø)
fabasoad commented 1 year ago

Hi @macisamuele! Addressed all the comments. Please review 🙂

vorburger commented 1 year ago

Maybe also document the new parameter on the README?

fabasoad commented 1 year ago

Maybe also document the new parameter on the README?

Good point. Added to FAQ section. Thanks!

Would be good to have more structured documentation for each separate hook with all listed parameters there, and their description. But this is another story for another PR I think.

macisamuele commented 1 year ago

@fabasoad will you have time to work on the suggestions of this PR?

fabasoad commented 1 year ago

@fabasoad will you have time to work on the suggestions of this PR?

I thought I addressed all the comments 3 weeks ago. Did I miss anything?

macisamuele commented 1 year ago

My bad... Seeing the comment associated to the github action change not resolved made me think that it was not covered yet. I've rechecked the changes and it is no longer there. Good to be merged. Thanks a lot for the contribution

fabasoad commented 1 year ago

Thanks @macisamuele! It was a great experience 🤝