Closed fabasoad closed 1 year ago
Merging #156 (1ebf251) into master (4bc272d) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #156 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 315 319 +4
=========================================
+ Hits 315 319 +4
Impacted Files | Coverage Δ | |
---|---|---|
..._formatters_pre_commit_hooks/pretty_format_java.py | 100.00% <100.00%> (ø) |
Hi @macisamuele! Addressed all the comments. Please review 🙂
Maybe also document the new parameter on the README?
Maybe also document the new parameter on the README?
Good point. Added to FAQ section. Thanks!
Would be good to have more structured documentation for each separate hook with all listed parameters there, and their description. But this is another story for another PR I think.
@fabasoad will you have time to work on the suggestions of this PR?
@fabasoad will you have time to work on the suggestions of this PR?
I thought I addressed all the comments 3 weeks ago. Did I miss anything?
My bad... Seeing the comment associated to the github action change not resolved made me think that it was not covered yet. I've rechecked the changes and it is no longer there. Good to be merged. Thanks a lot for the contribution
Thanks @macisamuele! It was a great experience 🤝
Adding
--google-java-formatter-jar
parameter to have possibility to use pre-downloaded formatter.Closes #119