Closed maresb closed 1 year ago
Thanks for working on this. Please add test coverage and I'll be happy to merge it
Excellent, thanks!!! I'll write some tests.
@macisamuele, ready for review. Thanks!
Running tests on the pr now. Later today or tomorrow, I'll fully review the changes even though I don't suspect any dramatic changes to be requested (if any).
Thanks a lot for contributing to the project.
Merging #160 (3883278) into master (8ced619) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #160 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 310 313 +3
=========================================
+ Hits 310 313 +3
Impacted Files | Coverage Δ | |
---|---|---|
..._formatters_pre_commit_hooks/pretty_format_toml.py | 100.00% <100.00%> (ø) |
Excellent, thanks! I'm looking forward to any feedback.
Awesome, thanks so much for being so open and responsive, and I really appreciate you taking care of the extra tests. If you remember, please ping me when the next tag comes out.
If there is interest in merging, let me know and I'll look into making tests.
Closes #152.