search

macisamuele / language-formatters-pre-commit-hooks

Collection of custom pre-commit hooks.
Apache License 2.0
115 stars 58 forks source link

Make ktlint log level configurable (or at least avoid debug logging when autofix is enabled) #176

Closed Velfi closed 1 year ago

Velfi commented 1 year ago

In the ktlint python script, ktlint is run with --log-level=debug.

This slows down the pre-commit check and I personally find it to be noisy. Would you entertain the idea of setting the default to info instead of debug or making it possible to configure/disable the logging?

macisamuele commented 1 year ago

Thanks for the report. As we collect failures via JSON reporter, I think that overriding the logging level is no longer needed. Feel free to open a PR where the log level definition is removed and I'll be happy to approve it.

Velfi commented 1 year ago

https://github.com/macisamuele/language-formatters-pre-commit-hooks/pull/177