search

macisamuele / language-formatters-pre-commit-hooks

Collection of custom pre-commit hooks.
Apache License 2.0
112 stars 56 forks source link

Add an option for inline-comment-spaces for toml #205

Closed alkatar21 closed 3 months ago

alkatar21 commented 6 months ago

Based on your https://github.com/macisamuele/language-formatters-pre-commit-hooks/issues/185#issuecomment-1751803889 I have now created a pull request to add this option.

What is the reason for the flag: I use the Even Better TOML VSCode extension in my project, which has no option to set this. To streamline the tools, I think it's easiest to add the option here.

I have extended #160 for the implementation. Let me know if you come up with any better names.

Hint: I have not executed the code locally, but I assume the tests run once after the approvel in the CI?

alkatar21 commented 3 months ago

I used github.dev to create the PR and therefore could not test it, which is why 2 errors sneaked into the tests. I hope that all errors have now been fixed.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (97a46d9) to head (39e67c5).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #205 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 10 10 Lines 333 334 +1 ========================================= + Hits 333 334 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

macisamuele commented 3 months ago

I used github.dev to create the PR and therefore could not test it, which is why 2 errors sneaked into the tests. I hope that all errors have now been fixed.

@alkatar21 no worries ... it is all good. I was just about to checkout the PR and have it fixed such that within the day I could have released the new version including this.