search

macisamuele / language-formatters-pre-commit-hooks

Collection of custom pre-commit hooks.
Apache License 2.0
112 stars 56 forks source link

Remove py2 code #226

Closed mxr closed 3 months ago

mxr commented 3 months ago

Related to #225

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (7ac9693) to head (7d153d3). Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #226 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 10 10 Lines 336 334 -2 ========================================= - Hits 336 334 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mxr commented 3 months ago

It's up to you as the maintainer what you want to support. If it's not a burden, then go for it.

In that vein, I would suggest adding all supported versions you support to the CI matrix, so you can be confident in supporting them properly. Also, it's a best-practice to specify python_requires>=xxx in setup.py (docs) if you ever want to remove support for lower versions.