macisamuele / language-formatters-pre-commit-hooks

Collection of custom pre-commit hooks.
Apache License 2.0
112 stars 56 forks source link

pre-commit requires python3.10 #232

Open eirnym opened 3 days ago

eirnym commented 3 days ago

Hi,

pre-commit used in this project requires python 3.10. Currently i have python 3.12 as a primary python version and python 3.13 will out.

What exactly is holding this project to use available Python 3, not the specific version?

In my projects I use matrix to test on multiple versions

macisamuele commented 3 days ago

Are you referring to the python version defined in the tox environment?

eirnym commented 2 days ago

I refer to pre-commit hooks specifically, tox works fine on my local environment.

macisamuele commented 2 days ago

I could bump it , but the main reason to not have it automatically pick any python3 version available is to make sure that the execution is predictable.

eirnym commented 2 days ago

I understand. What is the impact of removing these lines if this project explicitly specifies Python 3 as a Python for development?