search

macisamuele / language-formatters-pre-commit-hooks

Collection of custom pre-commit hooks.
Apache License 2.0
116 stars 58 forks source link

Deprecate usage of third-party mock lib and install all needed typesheds #71

Closed macisamuele closed 3 years ago

macisamuele commented 3 years ago

This PR aims to remove usage of mock library (meant to be a backport of unittest.mock for Python versions before 3.3) and to fix the mypy reports identified on #69.

The mypy issues are essentially related to the fact that mypy does not find the typesheds for pkg_resources and requests library and as such it fails (because mypy is configured to be extra severe). By installing them we make sure that mypy is happy.

codecov[bot] commented 3 years ago

Codecov Report

Merging #71 (daa4f27) into master (b6b0784) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #71   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          321       321           
=========================================
  Hits           321       321

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b6b0784...daa4f27. Read the comment docs.