codecov[bot]
commented
3 years ago Codecov Report
Merging #79 (55cd791) into master (5e38a5d) will not change coverage. The diff coverage is
100.00%.:exclamation: Current head 55cd791 differs from pull request most recent head 0abfff5. Consider uploading reports for the commit 0abfff5 to get more accurate results
@@ Coverage Diff @@
## master #79 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 291 337 +46
=========================================
+ Hits 291 337 +46 | Impacted Files | Coverage Δ | |
|---|---|---|
| ...uage_formatters_pre_commit_hooks/pre_conditions.py | 100.00% <100.00%> (ø) |
|
| language_formatters_pre_commit_hooks/utils.py | 100.00% <0.00%> (ø) |
|
| language_formatters_pre_commit_hooks/__init__.py | 100.00% <0.00%> (ø) |
|
| ...e_formatters_pre_commit_hooks/pretty_format_ini.py | 100.00% <0.00%> (ø) |
|
| ..._formatters_pre_commit_hooks/pretty_format_java.py | 100.00% <0.00%> (ø) |
|
| ..._formatters_pre_commit_hooks/pretty_format_rust.py | 100.00% <0.00%> (ø) |
|
| ..._formatters_pre_commit_hooks/pretty_format_toml.py | 100.00% <0.00%> (ø) |
|
| ..._formatters_pre_commit_hooks/pretty_format_yaml.py | 100.00% <0.00%> (ø) |
|
| ...ormatters_pre_commit_hooks/pretty_format_golang.py | 100.00% <0.00%> (ø) |
|
| ... and 1 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 5e38a5d...0abfff5. Read the comment docs.
The PR adds an helper method to allow determining the current Java JRE version available on the system as Google Java Formatter and KTLint are actually dependent on it.
In short:
In order to unblock some changes that would allow us to actually release the new version of the library (#78) I'm proposing a separate PR such that @cortinico can focus on the KTLint issue while I'll be focusing on the Google Java Formatter one.