search

macisamuele / language-formatters-pre-commit-hooks

Collection of custom pre-commit hooks.
Apache License 2.0
118 stars 57 forks source link

Use shutil.move for moving downloaded artifacts #84

Closed draftcode closed 3 years ago

draftcode commented 3 years ago

os.rename fails when the source and destination are in the different filesystem. shutil.move takes care of that difference.

Fixes https://github.com/macisamuele/language-formatters-pre-commit-hooks/issues/82

macisamuele commented 3 years ago

This evening I'll be checking this, but if I remember it right it was fixed in one of the previous PRs.

codecov[bot] commented 3 years ago

Codecov Report

Merging #84 (ecd9b53) into master (f581e56) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #84   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          315       315           
=========================================
  Hits           315       315
Impacted Files Coverage Δ
language_formatters_pre_commit_hooks/utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f581e56...ecd9b53. Read the comment docs.

draftcode commented 3 years ago

No rush. Please check on your side as well. I found this issue on master, and with this patch (and the other dependency fix that you've already merged), I confirmed this works.