search

macite / swingame

2D game library accessible from multiple languages
swingame.com
27 stars 9 forks source link

Compiling SGSDL2 generates lots of warnings about macro names and old style casting. #34

Closed Aloz1 closed 8 years ago

Aloz1 commented 8 years ago

This is annoying and makes it hard to see other issues. It seems the most common problems are related to reserved macro identifiers and using old style casts. Having a quick look, casting is a fairly trivial warning to fix, by replacing all instances of pointer casting with static_cast(data). Also, general macro naming conventions for C++ dictate that there should not be any double underscores in the name, nor should the name begin or end with an underscore as these are reserved identifiers for compilers.

Aloz1 commented 8 years ago

This has been merged, so I'm marking it as resolved.