search

macjabeth / showbunny

Watch and track your favourite movies and tv shows.
https://showbunny.xyz/
MIT License
6 stars 12 forks source link

Need a responsive navigation bar for easy access of the website's resources #36

Closed ARJITMALIK closed 3 years ago

ARJITMALIK commented 3 years ago

Hey @macjabeth , I think you should add a neat navigation bar on your website for easier navigation through movies/shows.

If you want I will make a nice and responsive floating navigation bar for your website using css with bootstrap 5 😃😃

macjabeth commented 3 years ago

Hey @ARJITMALIK!

That is a fantastic idea, and would be extremely appreciated.

However, for this project, we are attempting to avoid using any frameworks (such as Bootstrap) and instead rely on vanilla CSS and JavaScript to complete tasks. As such, it provides an interesting challenge and learning experience.

Some other things to note:

I'd like to have separate sections developed using web components. This brings a lot of advantages in terms of maintenance and reusability.

I'd also ask that you adopt this concept as inspiration for the design, as it's what I'm using for the rest of the site.

So, if you're up to the challenge, go ahead and take it away! Please add your changes to a feature branch and make your PR to the rebirth branch.

(PS. Love the profile pic of Naruto in sage mode!)

ARJITMALIK commented 3 years ago

Alright, I would love to work on web components btw thanks for the compliment on my profile, DATTEBAYO!✌️

macjabeth commented 3 years ago

Alright, I would love to work on web components

Hey @ARJITMALIK - just wanted to give a heads up if you're working on this, I added in an example of a working web component for the movie posters. Feel free to look it over and use it as inspiration for the navbar. 🙂

Thanks again for taking this on! And, if you're interested, I'll be streaming more live development of this site on my Twitch channel tomorrow at 2 p.m. CDT.

ARJITMALIK commented 3 years ago

That would be a great help, thanks for your efforts✌️😊

ARJITMALIK commented 3 years ago

Morning @macjabeth , please take a look into my modifications

I have created a pull request for the same to your develop branch.

And thanks again for providing this opportunity , got to learn a bunch of new techniques to stylize using CSS. 😃😃

macjabeth commented 3 years ago

Thanks for the PR, @ARJITMALIK! I merged it in last weekend.

While reviewing it however, I noticed it wasn't responsive on mobile screens, so it needed some modifications before I could push it to the live site. I also removed the search bar (for now) until we're ready to implement a site-wide search feature.

Feel free to join our Discord for more discussion on Showbunny and other topics. 🙂

ARJITMALIK commented 3 years ago

Yeah sure, I will look into that ✌️