search

macjabeth / showbunny

Watch and track your favourite movies and tv shows.
https://showbunny.xyz/
MIT License
6 stars 12 forks source link

Remove background url & added img tag #37

Closed d4rkener closed 3 years ago

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/macjabeth/showbunny/AZcDz9HpcytYefLzZbi6YYtU7dQp
✅ Preview: https://showbunny-git-fork-rahulshawdev-rahulshawdev-s-f57385-macjabeth.vercel.app

macjabeth commented 3 years ago

Hello, Rahul - thank you for the PR!

The update looks good, but there are a few things I'd like to see before merging it.

  1. document.createElement should be used to create the image tag separately, instead of defining it in the innerHTML.

  2. As stated in #33, I'd like it to include a srcset of various sizes so that the image quality is optimized for each device. Instead of pixel density, it should employ width descriptors. Please see the issue description for a link to the API results which show available poster image widths.

  3. This will likely involve some changes to the CSS so it conforms to the correct image width.

If you have any other questions, let me know.