search

mackdk / gnome-github-manager

Integrate GitHub within the GNOME Desktop Environment
GNU General Public License v2.0
8 stars 2 forks source link

Extension not recognized #10

Open RedBoardDev opened 1 year ago

RedBoardDev commented 1 year ago

Hello ! First, thank you for continuing to update this project. I have cloned the repo correctly, but the "Extensions Manager" software does not find the extension. Here are my specifications: Fedora 37 Gnome 43.4

mackdk commented 1 year ago

Hi. If you were trying to follow the README, I'm afraid but that is not up to date. The extension is written in typescript now, not in javascript. It needs to be compiled, and to do that you need to install NodeJS and other development tools. The reality is this project is not yet ready to be used in its current shape.

mackdk commented 1 year ago

You can follow issue #4 to see when a proper documentation will be added.

RedBoardDev commented 1 year ago

Hi. If you were trying to follow the README, I'm afraid but that is not up to date. The extension is written in typescript now, not in javascript. It needs to be compiled, and to do that you need to install NodeJS and other development tools. The reality is this project is not yet ready to be used in its current shape.

Yes the README is not up to date x'D EDIT: With your latest commit, I've build and compil with yarn and the extension work !! I will do some test, like see if I can have notification when someone commit on a repository on an organisation or just on a private repository.

mackdk commented 1 year ago

if I can have notification when someone commit on a repository on an organisation or just on a private repository

It seems to me you are referring to email notifications for pushes. I'm not sure if you can see those in the GitHub notifications page and thus with this extension.

And, by the way, you will need to add the repo scope to your token, otherwise you will only be able to open the generic notifications page for events on private repositories.

Anyway, let me know the results of your experiments :+1:

RedBoardDev commented 1 year ago

I have read some article and I can't get notification when someone commit on the organisation. And I'm just member so I can't setup something for that. For the token I've select "notifications" and configure "Configure SSO" for the organisation. So sad x'D But actually your extension work. I have already receive 1 notification (your response) today. I will see if it's work with private and public repository but I think it's good !

mackdk commented 1 year ago

For the token I've select "notifications" and configure "Configure SSO" for the organisation.

notifications is enough for public repositories but you may want to set up also repo, if you use private repositories. Otherwise, when clicking on the notification to open it, it won't bring you to the specific page (the issue/pull request/thread where you have updates) but on the generic notification page. This is because without the repo permission the extension cannot retrieve from the API the url to open. Another topic I need to explain which have it's own ticket: #5 :man_facepalming:

I have read some article and I can't get notification when someone commit on the organisation.

This actually might be an interesting feature request. I can have a look if it is something doable with the APIs.