mackerelio / mackerel-agent

mackerel-agent is an agent program to post your hosts' metrics to mackerel.io.
https://mackerel.io
Apache License 2.0
427 stars 88 forks source link

Include other configuration files #16

Closed sorah closed 10 years ago

sorah commented 10 years ago

I'm happy if mackerel-agent accepts include configuration to load additional configuration files and merge them.

include = /etc/mackerel-agent/conf.d/*

It's familiar to some automation tools such like Chef, Puppet, if user wants to new module with new metrics, User can write new mackerel configuration file for the module and put into conf.d directory.

But with current implementation, user have to implement merging multiple configuration files in their puppet, chef manifests.

Thoughts?

stanaka commented 10 years ago

Implementing include is a good idea.

But include is not defined officially in toml. Referring to .gitconfig seems to be fine way?

sorah commented 10 years ago

Yes I've looked TOML reference at first but there's nothing include feature in there.

I think we should implement like .gitconfig if we wanted include feature.

motemen commented 10 years ago

Finally implemented in version 0.11.1! http://blog-ja.mackerel.io/entry/2014/08/07/164834

Closing this Issue, open new one if you have any problems.

sorah commented 10 years ago

:sparkles: