ci: run Danger on PRs - Githubissues

macklinu / danger-plugin-jest

Danger plugin for Jest

MIT License

23 stars 9 forks source link

ci: run Danger on PRs #24

Closed macklinu closed 7 years ago

macklinu-bot commented 7 years ago

	Messages
:book:	:white_check_mark: Jest tests passed

Generated by :no_entry_sign: dangerJS

orta commented 7 years ago

I don't think relative file compilation works ATM, would recommend doing it to the list directory

macklinu commented 7 years ago

Sorry @orta, not sure I follow your comment. What do you suggest for next steps?

orta commented 7 years ago

run yarn build, then refer to the JS files in the Dangerfile

orta commented 7 years ago

Looks good, can probably just make Danger only run on 6 or node and you're 👍

macklinu commented 7 years ago

I'm just going to build on Node 6 for now on Travis, since 4 and 8 are erroring before any of the useful commands run (build, lint, test, danger). Will come back around and figure out the Node 8 build. Might just drop building on Node 4. 🤷‍♂️