Add option to disable success message

macklinu / danger-plugin-jest

Danger plugin for Jest

MIT License

23 stars 9 forks source link

Add option to disable success message #25

Closed mxstbr closed 5 years ago

mxstbr commented 7 years ago

I don't particularly care to see the Danger comment if the Jest tests pass, I can see that in the commit status, I mainly care about seeing the test failures right on GitHub when they fail!

It'd be great if there was an option to disable posting a success message so the comment gets deleted once all tests pass:

/cc @orta

macklinu commented 7 years ago

I'd be open to removing this behavior by default in v2.0 while also supplying a successMessage option for those who would like the current behavior. Wondering if having a message at all on success is valuable - you make a good point with the GitHub commit status being ✅, so having a message for every success might just become unnecessary noise.

mxstbr commented 7 years ago

Sounds great to me!

orta commented 7 years ago

I removed that message in #23

macklinu commented 5 years ago

I think this was resolved in #23. 🙇