macklinu / danger-plugin-jest

Danger plugin for Jest
MIT License
23 stars 9 forks source link

PR comment fails if message is too long #52

Open Djiit opened 5 years ago

Djiit commented 5 years ago

Hi there,

Here is what I got from Jenkins when dealing with a 100+ failed snapshots result :

11:03:16  + yarn danger ci
11:03:16  yarn run v1.15.2
11:03:16  $ /home/agentadmin/workspace/front-newlook_PR-2433/node_modules/.bin/danger ci
11:03:21  Jest tests passed :+1:
11:03:21  
11:03:21  
11:03:22  Failing the build, there is 1 fail.
11:03:27  Request failed [422]: https://api.github.com/repos/onedior/front-newlook/issues/comments/477510827
11:03:27  Response: {
11:03:27    "message": "Validation Failed",
11:03:27    "errors": [
11:03:27      {
11:03:27        "resource": "IssueComment",
11:03:27        "code": "custom",
11:03:27        "field": "body",
11:03:27        "message": "body is too long (maximum is 65536 characters)"
11:03:27      }
11:03:27    ],
11:03:27    "documentation_url": "https://developer.github.com/v3/issues/comments/#edit-a-comment"
11:03:27  }
11:03:27  Feedback: undefined
11:03:28  Done in 11.56s.

Should we truncate the file if it is too long ?

rohit-gohri commented 5 years ago

Related issue in danger-js: https://github.com/danger/danger-js/issues/919