macklinu / danger-plugin-tslint

Danger plugin for TSLint
MIT License
10 stars 3 forks source link

ci(danger): run Danger on PRs #6

Closed macklinu closed 7 years ago

macklinu commented 7 years ago

🚫

resolves #3

macklinu-bot commented 7 years ago
Messages
:book: :white_check_mark: TSLint passed

Generated by :no_entry_sign: dangerJS

macklinu commented 7 years ago

That should have failed. Wondering if users should use something like npm run lint --silent -- -t json | tee reports/tslint-report.json, and then this plugin could read that file and pretty print it? Not sure how to resolve this issue at the present - will need to look into the TSLint API.

macklinu commented 7 years ago

I am going to rebase this against #7 once it's merged.

macklinu commented 7 years ago

Re: https://github.com/macklinu/danger-plugin-tslint/pull/6#issuecomment-304103475, I rewrote this plugin and shipped it as v2.0.0.