search

mackron / miniaudio

Audio playback and capture library written in C, in a single source file.
https://miniaud.io
Other
4.07k stars 361 forks source link

Possible regresion when compiling for Web with Emscripten #773

Closed raysan5 closed 1 year ago

raysan5 commented 1 year ago

Just detected a possible regression. When compiling raylib with latest miniaudio v0.11.20 there are cracks in the audio: https://www.raylib.com/examples/audio/audio_music_stream.html

I reverted to older miniaudio versions and I found the Web version was crashing at v0.11.18 and also at v0.11.16:

image

Down to miniaudio v0.11.12 it worked perfectly.

I also tried increasing the subBuffer size in raudio but the cracks persist.

I'm planning next raylib 5.0 release by November 18 and it would be great to have this issue fixed, but if not possible I can rever to miniaudio v0.11.15.

Environment: Windows 10, 64 bit, Chome Version 119.0.6045.124 (Official Build) (64-bit)

EDIT: Tested with v0.11.15 and it works as expected.

mackron commented 1 year ago

Fixed in the dev branch.

raysan5 commented 1 year ago

@mackron Thank you very much for the fast review and fix! Already updated raylib! 😄