awk's close needs to be a function, not a statement

mackyle / topgit

TopGit - A different patch queue manager

https://repo.or.cz/topgit/pro.git

Other

67 stars 7 forks source link

awk's close needs to be a function, not a statement #1

Closed pmolodo closed 7 years ago

pmolodo commented 7 years ago

(for awk 4.0.2, anyway)

matttbe commented 7 years ago

Hi @mackyle

I confirm that @elrond79 's patch fixes this issue:

awk: cmd. line:5:           close fn
awk: cmd. line:5:                 ^ syntax error

Could it be merged/integrated in your repo?

PS: thank you both for this nice tool and fixes!

mackyle commented 7 years ago

You're right. Apparently my version of awk (*BSD) silently allows that, but it's definitely not in the POSIX spec.

I'll cherry pick your patch in the style of Git maintenance.

See https://github.com/git/git/blob/master/Documentation/SubmittingPatches section (5).

If you add a Signed-off-by line certifying the patch as yours (see section (5) in the above doc) otherwise I can just fix it if you are unable to do that.

mackyle commented 7 years ago

fix released in topgit-0.19.8.