mackyle / topgit

TopGit - A different patch queue manager
https://repo.or.cz/topgit/pro.git
Other
67 stars 7 forks source link

Update INSTALL #13

Closed etam closed 5 years ago

etam commented 5 years ago

fix openSUSE package url

etam commented 5 years ago

(github editor seems to have added newline at the end of file)

mackyle commented 5 years ago

So here's a cleaned up version of the URL:

https://software.opensuse.org/download.html?project=devel:tools:scm&package=topgit

BUT the version(s) offered on that page are really outdated (anything that still installs a leaves.awk file is really old in terms of features, functionality and speed).

Unless you know of a more up-to-date link?, I'm inclined to just remove that line entirely. It's simple enough to install TopGit by cloning the repo and using make install especially since only a POSIX make etc. is required now.

etam commented 5 years ago

The updated version is on it's way: https://build.opensuse.org/request/show/666022

etam commented 5 years ago

I cleaned up the url and reverted the EOL at EOF change. My request on openSUSE Build Service was also accepted, so it's the latest version there now.

mackyle commented 5 years ago

Looks good except for a missing SOB line if you could please add one then I can take the commit as-is.

FYI, looking at:

https://build.opensuse.org/package/show/devel:tools:scm/topgit

I see two failures and one blockage but the older package is available for both of the fails as well as the blocked (which it probably shouldn't be if the block reason is accurate).

etam commented 5 years ago

what's "SOB line"?

mackyle commented 5 years ago

Take a look at:

https://github.com/git/git/blob/master/Documentation/SubmittingPatches#L294

While it's true this is only a one-line change and just to text at that, without an SOB line I'll end up committing the change myself while giving you credit for reporting it. But if you include an SOB line in your patch I'll just go ahead and take it with you as the author.

etam commented 5 years ago

done

mackyle commented 5 years ago

applied and pushed. thanks.