search

mackyle / topgit

TopGit - A different patch queue manager
https://repo.or.cz/topgit/pro.git
Other
67 stars 7 forks source link

Rename $(T) to $(TESTSUITE) #21

Closed winterheart closed 3 years ago

winterheart commented 3 years ago

$(T) is used in Gentoo for temp directory during building package (see https://bugs.gentoo.org/739088).

mackyle commented 3 years ago

I'm inclined to reject this unless you can show me a similar patch being accepted to Git that changes its t/Makefile to stop using T.

I do note however that while this fails:

T=broken
export T
make test

This does not:

T=broken
export T
make T= test

Setting T= on the make command line will be treated the same way as T not being set and run all tests.

I suggest that you alter the command that runs the tests to include the T= bit.

How do you deal with running the Git tests? TopGit's test suite framework is, after all, just a modified version of Git's.

winterheart commented 3 years ago

OK, seems setting T= is working solution for redefined $T variable, I'll use that in buildsystem. Thank you for clarification.