don't strip [tag] blocks from subject (except for [PATCH])

mackyle / topgit

TopGit - A different patch queue manager

https://repo.or.cz/topgit/pro.git

Other

67 stars 7 forks source link

don't strip [tag] blocks from subject (except for [PATCH]) #3

Closed pmolodo closed 7 years ago

pmolodo commented 7 years ago

Many repositories use "[Tag]" blocks in their commit messages as a convention - ie:

https://github.com/PixarAnimationStudios/USD/commit/34075ef30efc9aa94a0c1e05c6e2d6f56d2a4853

The current version of topgit automatically strips out ALL such blocks - this scommit changes it so that it only strips out "[Patch]".

mackyle commented 7 years ago

Same comment as #1 and #2, please add a Signed-off-by: to certify your change.

Also please add a comment to the commit message about why it's okay to use the "-b" option (because it was added in Git v1.6.6 in 17635fc900674037 and TopGit requires at least Git v1.8.5).

mackyle commented 7 years ago

Won't be using git mailinfo -b. Sorry.

For the reason why see https://github.com/git/git/commit/ae52d57f0b45b2db.

Apparently -b is short for “buggy” ;)

But I’ll get something in the next release for this; it just won’t use that option.

mackyle commented 7 years ago

addressed in topgit-0.19.8.