maclandrol / FisherExact

Fisher exact test for mxn contingency table in python
MIT License
37 stars 12 forks source link

Problem using a 3x3 matrix #5

Closed jaumesastretomas closed 6 years ago

jaumesastretomas commented 6 years ago

Hi, I am using the following matrix:

3 3

159 4 80 3 25 0 30 0 108

And I obtained the pvalue=0

Why is that?

Is not possible to use mxm matrices?

Thanks.

maclandrol commented 6 years ago

It should definitively work. I got :

Pvalue : 1.50266533e-47

I assume you are using the binary. There was a bug in the pvalue printing that was fixed in commit cdf4684c5 some while ago. If you install using the github repository, then there shouldn't be any problem. However I forgot to update the pypi version so the bug was still there (binary only). I fixed it.

Thanks.

jaumesastretomas commented 6 years ago

Ok now it worked!

I re-installed the binary.

thanks.

Jaume

2018-02-22 7:27 GMT+01:00 Emmanuel Noutahi notifications@github.com:

It should definitively work. I got :

Pvalue : 1.50266533e-47

I assume you are using the binary. There was a bug in the pvalue printing that was fixed in commit cdf4684 https://github.com/maclandrol/FisherExact/commit/cdf4684c519c9334aad1c1e9fcd17dcdbc22101a some while ago. If you install using the github repository, then there shouldn't be any problem. However I forgot to update the pypi version so the bug was still there (binary only). I fixed it.

Thanks.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/maclandrol/FisherExact/issues/5#issuecomment-367580378, or mute the thread https://github.com/notifications/unsubscribe-auth/AHDkOVGBLWVdn-wN_CAjnH_ym8tRBvh7ks5tXQjLgaJpZM4SOZW8 .[image: Web Bug from https://github.com/notifications/beacon/AHDkOVbI5Hwznx5m-FE1-a9GUtcnH1Sdks5tXQjLgaJpZM4SOZW8.gif] {"api_version":"1.0","publisher":{"api_key":" 05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity": {"external_key":"github/maclandrol/FisherExact","title":"maclandrol/ FisherExact","subtitle":"GitHub repository","main_image_url":" https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88- 11e6-95fc-7290892c7bb5.png","avatar_image_url":"https:// cloud.githubusercontent.com/assets/143418/15842166/ 7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/maclandrol/FisherExact"}}, "updates":{"snippets":[{"icon":"PERSON","message":"@maclandrol in #5: It should definitively work. I got :\r\n\r\nPvalue : 1.50266533e-47\r\n\r\nI assume you are using the binary. There was a bug in the pvalue printing that was fixed in commit cdf4684c5 some while ago. If you install using the github repository, then there shouldn't be any problem. However I forgot to update the pypi version so the bug was still there (binary only). I fixed it. \r\n\r\nThanks."}],"action":{"name":"View Issue","url":" https://github.com/maclandrol/FisherExact/issues/5#issuecomment-367580378 "}}}