search

macmillanpublishers / Word-template

Macmillan's styles and template
ISC License
4 stars 4 forks source link

[ss] Create JSON to store section-head rules #218

Closed nelliemckesson closed 7 years ago

nelliemckesson commented 7 years ago

Store the new section-head rules in a JSON file that will be read by both the VBA and JS scripts.

MacmillanWorkflows commented 7 years ago

➤ Matthew Retzer commented: This is created; the mock-up here: https://docs.google.com/spreadsheets/d/1CBsk8kJLgy8PGsjTbmjT5KJO2Cg30x_4i3Tjt-7JQI0/edit#gid=2123523468 and an actual json of same in a branch I have for the validator: https://github.com/macmillanpublishers/bookmaker_validator/blob/rulesjson/ss_rules.json

https://app.asana.com/0/142682776454805/142682776454805 and https://app.asana.com/0/142682204252343/142682204252343.. is the root of bookmaker_validator an ok place for this json to live? Any further changes you wanted me to make to the form/format/nomenclature? (Don't feel like you need to come up with a change, cuz I've already started to build around it ;)

ericawarren commented 7 years ago

I'm OK with the JSON living in bookmaker_validator. I'll need to create a config file for it at some point, since that is how the Word-template will download/update it for users and locate it in the local installation.

nelliemckesson commented 7 years ago

Yeah I think it makes sense in validator. Make sure you reference it in a way that it's easy to move it if we decide we want to, though.

MacmillanWorkflows commented 7 years ago

➤ Matthew Retzer commented: OK, I am submitting a PR for bookmake_validator shortly, including the JSON... and closing this issue in the meantime

MacmillanWorkflows commented 7 years ago

➤ Matthew Retzer commented: Here is the PR including this: https://github.com/macmillanpublishers/bookmaker_validator/pull/97