remove bundler version dependencies

macmillanpublishers / bookmaker

Macmillan's Bookmaker tool

ISC License

27 stars 2 forks source link

remove bundler version dependencies #157

Open nelliemckesson opened 7 years ago

nelliemckesson commented 7 years ago

@mattretzer I think we should remove the version dependencies in bundler whenever possible. It causes bookmaker to crash if any gem versions are out of date, which is bad. But I'm open to other arguments.

mattretzer commented 7 years ago

Wow, I don't think that's supposed to happen :( Let me know if you want me to change this today or if we can wait and discuss Thursday?

nelliemckesson commented 7 years ago

Let's discuss Thursday. FYI this was when I was running it on my local machine, which comes with some extra issues, so presumably it wouldn't crash on the server versions.

stefanv commented 7 years ago

I've run into this issue as well. It may be worth reviewing the README installation instructions as well; they don't work unmodified (at least, not on a modern OSX brew system). E.g., note:

Current dependencies cannot be installed under Ruby 1.9 (the version advocated)
Dependencies can be installed as follows (I'm not a Ruby user, so I don't know if this is the best way):

gem install bundler
bundler install