edits to htmlmaker.rb so it chooses js or xsl conversion based on the template_version
and some of the old js code, consolidated & re-added, to support the xsl conversion.
One comment/question:
In htmlmakerpreprocessing.rb I am writing the template_version-string to the config.json file.
htmlmaker.rb then scoops up this value from the config.json file and writes it into the html as a meta element.
However when metadatapreprocessing.rb runs, it overwrites the existing config.json, so that value is no longer in config.json. It doesn’t matter functionally; I could also re-write the value in metadatapreprocessing if we wanted.
I could also read the value from the json logfile instead and skip using the config.json entirely? I did read a value from the jsonlog output of htmlmaker.rb to detect js vs xsl conversion in metadata_preprocessing.rb. Let me know what you think:)
Hi @nelliemckesson , this PR, together with its companion PR in addons, include:
One comment/question: In htmlmakerpreprocessing.rb I am writing the template_version-string to the config.json file. htmlmaker.rb then scoops up this value from the config.json file and writes it into the html as a meta element. However when metadatapreprocessing.rb runs, it overwrites the existing config.json, so that value is no longer in config.json. It doesn’t matter functionally; I could also re-write the value in metadatapreprocessing if we wanted. I could also read the value from the json logfile instead and skip using the config.json entirely? I did read a value from the jsonlog output of htmlmaker.rb to detect js vs xsl conversion in metadata_preprocessing.rb. Let me know what you think:)