search

macmillanpublishers / covermaker

Automated creation of cover image files
0 stars 1 forks source link

hiding header elements on titlepage #41

Closed mattretzer closed 7 years ago

mattretzer commented 7 years ago

@nelliemckesson , please review, seems to work fine, tested with Swerve & tor.com titles.
This is to resolve https://github.com/macmillanpublishers/covermaker/issues/40

I am requesting merge into master b/c since there are no 'header' elements in our existing html it should have no effect on current runs (I ran the testing manuscript through too and was fine)

nelliemckesson commented 7 years ago

I feel like this should be fixed with this, so I'm curious why it's not catching these: https://github.com/macmillanpublishers/bookmaker_addons/blob/sectionstartstaging/epubmaker_preprocessing.js#L159

For EPUBs, we actually want to strip all header elements entirely, since there's no guarantee that EPUB reading systems will all correctly honor the "display" property.

nelliemckesson commented 7 years ago

I'm going to approve this anyways and you should go ahead and merge in the change, since it's good to have as a backup, but keep the corresponding issue open and try to see if you can sort out why the removal isn't working for titlepages.