macmillanpublishers / htmlmaker_js

Repo for testing and finalizing htmlmaker javascript implementation
0 stars 1 forks source link

discrepancy in ebook with backad position/sequence #39

Closed mattretzer closed 7 years ago

mattretzer commented 7 years ago

These may be desired behaviors, but noting them regardless, as discrepancies from the xsl-html-conversion toolchain:

mattretzer commented 7 years ago

I am renaming this issue and splitting it into 2 parts - this issue will have to do with the realtive positioning of the bobad in epub; created a new issue for bobad entry into ncx: https://github.com/macmillanpublishers/htmlmaker_js/issues/49

mattretzer commented 7 years ago

More notes about the relative placement of the Section-Back-Ad in the epub, after looking over more cases of this:

I've seen several methods used to style Bobads in our original test manuscripts; in one it was just at the end of another section; in one there is a bobad-Title styled-para to indicate a bobad section, in one it was in it's own section with a ChapTitleNonprinting :(.

It looks like it was supposed to be indicated with a BOB Ad Title (bobt) styled para, which was then moved to back of book via this code in bookmaker_addons. It comes after the 'move about the author to back', so the BOBAD should appear after the ATA.

• From what I can tell (?) the above code will not act upon a Section-Back-Ad section unless it also has a BOB Ad head or other bobad style, which will not necessarily be the case; so we would need to edit this. • (we may want to look at all of the "localMoveSection" method calls in epubmaker_preprocessing.rb and see if this might be an issue with any other items.

Example manuscripts: https://www.dropbox.com/s/0a0nx7bzoo6p2ps/9781250105868_MNU_NEW.docx?dl=0 https://www.dropbox.com/s/1wm499esgg6q4fp/9781250119971_MNU_NEW.docx?dl=0 https://www.dropbox.com/s/cc3tgm6bgi022mr/9780765389831_MNU_ctnp-removed.docx?dl=0

mattretzer commented 7 years ago

We need to make sure our section has this class, or this contains our section's class here. And we should go over the rest of these to make sure we don't have the same issue: https://github.com/macmillanpublishers/bookmaker_addons/blob/master/epubmaker_preprocessing.rb#L296-L318

MacmillanWorkflows commented 7 years ago

➤ Matthew Retzer commented:

This will be resolved by this PR (pending review) https://github.com/macmillanpublishers/htmlmaker_js/pull/64 which includes the class update for Section-Backads in the style-config.json. There are no other class mismatches for the relevant sections between sections.json and style-config.json