macmillanpublishers / htmlmaker_js

Repo for testing and finalizing htmlmaker javascript implementation
0 stars 1 forks source link

htmlmaker_js: htmlmaker created some spans from custom styling! #40

Closed mattretzer closed 7 years ago

mattretzer commented 7 years ago

In this document there are some places were text was italicized using Word italics (the 'i' button) instead of styles. The htmlmaker-js included the italicization as a span in the html output: <span style="font-style: italic;">she</span> And in both the pdf and epub output, the span's style declaration was honored; the selected text was italicized.

Context for an occurrence in the Word doc: " A distraction, a sacrifice. As it&#x2014;as <span style="font-style: italic;">she</span><span style="font-style: italic;">,"

I am no noticing that actually many places in this doc both the span-italic style and Word italics are used, so a lot of places both spans are present in the html.

mattretzer commented 7 years ago

Found more of these in this document

mattretzer commented 7 years ago

Encountered again in this document, this time with bold, and bold-italic combined. This snippet is from html in the adcard section: <span style="font-weight: bold; font-style: italic;">Nine Circles </span><span style="font-weight: bold;">series</span>

mattretzer commented 7 years ago

We should add a new script to addons to convert inline styling to the correct elements & classnames etc. IT should be invoked in htmlmakerpostprocessing.rb