search

macmillanpublishers / htmlmaker_js

Repo for testing and finalizing htmlmaker javascript implementation
0 stars 1 forks source link

epub has ncx entries for both Section-ExcerptOpener And Section-ExcerptChapter #41

Closed mattretzer closed 7 years ago

mattretzer commented 7 years ago

This is an expected behavior when using section starts; just noting another discrepancy from epub output from htmlmaker_js toolchain versus xsl toolchain so we can decide whether we want to change it. File here.

mattretzer commented 7 years ago

(In the XSL version, the Excerpt Opener is styled as ChapTitleNonPrinting, so it has an ncx entry ; but the Section-Excerpt-Chapter does not. That would probably be our ideal outcome for the js too, unless there are cases where Section-Excerpt-Chapter exists without Section-Excerpt-Opener.

This is related to this issue: https://github.com/macmillanpublishers/htmlmaker_js/issues/47

MacmillanWorkflows commented 7 years ago

➤ 9491251705208 commented:

We should suppress the SEC ncx entry; we think notoc class will do thetrick butwill need to test.

MacmillanWorkflows commented 7 years ago

➤ Matthew Retzer commented:

Submitted PR for this: https://github.com/macmillanpublishers/bookmaker_addons/pull/166

MacmillanWorkflows commented 7 years ago

➤ Matthew Retzer commented:

approved, merged & deployed