macmillanpublishers / htmlmaker_js

Repo for testing and finalizing htmlmaker javascript implementation
0 stars 1 forks source link

unnecessary nonprinting h1 generated for Section-Preface (one already existed) #44

Closed mattretzer closed 7 years ago

mattretzer commented 7 years ago

In this section-start styled manuscript, there is a Section-Preface with text entered ("Disclaimers"), followed by a para styled 'Head - Level 1 (h1)' with text content. During conversion htmlmaker created a new h1.Nonprinting with generic name 'Preface 2', which then also became the text for the ncx, instead of either "Disclaimers" or the content of the existing Head-Level-1, either of which would have been preferable.

Additionally the existing (visible) h1 did not get a reverse link to the ncx, since it had been converted to a p. Here's what's in the layout html post-conversion:

<section data-type="preface" id="sectid67gl4" class="">
        <header>
            <h1>Preface 2</h1></header>
        <h1 class="Nonprinting">Preface 2</h1>
        <p class="Head-Level-1h1" id="ide9lti333r">A NOTE ON SOURCE MATERIAL</p>
mattretzer commented 7 years ago

This would be considered 'user error", closing issue