search

macmillanpublishers / htmlmaker_js

Repo for testing and finalizing htmlmaker javascript implementation
0 stars 1 forks source link

[2] htmlmaker-js stripped out improperly styled hyperlink in back-ad #46

Closed mattretzer closed 6 years ago

mattretzer commented 7 years ago

In this manuscript, in the backad there is a hyperlink styled with native Word character style 'hyperlink'. In the xsl conversion, the resulting html includes the span as shown in the code below, but in the js-converted html, the whole hyperlink element is missing (including linked text): <p class="BOBAdLevel-2Subheadbobh2">For more information, visit <span class="spanhyperlinkurl">www.amarthur.blogspot.com</span></p>

MacmillanWorkflows commented 7 years ago

➤ Matthew Retzer commented:

submitted this PR for review: https://github.com/macmillanpublishers/htmlmaker_js/pull/66

MacmillanWorkflows commented 7 years ago

➤ Matthew Retzer commented:

should re-test as per Nellie's comment

MacmillanWorkflows commented 7 years ago

➤ Matthew Retzer commented:

1.5 hrs

MacmillanWorkflows commented 6 years ago

➤ Matthew Retzer commented:

re-reviewed, tested, merged.