search

macmillanpublishers / htmlmaker_js

Repo for testing and finalizing htmlmaker javascript implementation
0 stars 1 forks source link

Paras styled as captions are getting different tags in htmlmaker_js #60

Closed mattretzer closed 7 years ago

mattretzer commented 7 years ago

(Encountered when testing with our test manuscript)

Here is how a paragraph styles as "Caption (cap)" is tagged in the xsl-output html: <figcaption class="Captioncap">This is an image that is missing.</figcaption>

and here is the same element in htmlmaker_js html: <p class="Captioncap" id="idccmtx1922">This is an image that is missing.</p>

nelliemckesson commented 7 years ago

The XSL styling is correct. We should add the conversion after this block: https://github.com/macmillanpublishers/htmlmaker_js/blob/master/lib/htmltohtmlbook.js#L366 . We already source in the caption para list here: https://github.com/macmillanpublishers/htmlmaker_js/blob/master/lib/htmltohtmlbook.js#L48

MacmillanWorkflows commented 7 years ago

➤ Matthew Retzer commented:

This PR resolves this issue: https://github.com/macmillanpublishers/htmlmaker_js/pull/65