search

macmv / bamboo

A safe, fast, and secure Minecraft server optimized for minigames. This is a mirror of the Gitlab repo: https://gitlab.com/macmv/bamboo
https://gitlab.com/macmv/bamboo
MIT License
25 stars 1 forks source link

Rewrite Command Registration #18

Closed Snowiiii closed 10 months ago

Snowiiii commented 1 year ago

This cleans the World init function up, Do add every Command and its logic there was a messy way, Now its clean

Snowiiii commented 1 year ago

I don't really see why these should be split up? each command is pretty small, and moving them to their own files doesn't really do anything, except make each one harder to find. I'd be open to reasoning behind this, but right now I don't really get why this should be changed.

I'd be fine with splitting it into a couple files, but I don't see the need for a separate file for each command.

I like the abstraction using Files especilly larger Commands like the GameMode Command is more Readable, But when you want i can move all the Commands into the mod.rs File just your current Command Handeling makes not much sense, Your Registering Commands for every World, We should change this to just one Registration when Server loads, This can save unnecessary Complexity and Resource Usage, Spliting into "a couple of files" makes not much sense to me, We would just have a big mess, Some Commands have their Files some don't ?, Just No