search

macor161 / ts-money

Typescript port of js-money. Implementation of the Money value object.
MIT License
47 stars 9 forks source link

Why ECMAScript target version is ES6 but not ES5? #2

Closed maksim-kosolapov closed 2 years ago

maksim-kosolapov commented 4 years ago

IE doesn't support ES6 syntax, so I need to transpile ts-money module to ES5, seems to be better change target version to ES5 here to avoid similar problems.

macor161 commented 4 years ago

Hi @maksim-kosolapov, thanks for the suggestion. ES6 was chosen mainly because the vast majority of browsers and NodeJs support it. For what browser do you need ES5 exactly, Internet Explorer?

maksim-kosolapov commented 4 years ago

Yes, IE11 doesn't support ES6 yet. And as i know most node modules compiled in ES5, so no need to transpile them with babel to speed up build.

macor161 commented 2 years ago

Closing this now that IE is deprecated.