Use autolayout instead of manual calculations in `layoutSubviews`.

macoscope / GrandCentralBoard

Hang a TV in your open space or team room to show everyone what's up and get them up to speed.

http://macoscope.com/blog/grand-central-board-for-the-apple-tv/

GNU General Public License v3.0

203 stars 16 forks source link

Use autolayout instead of manual calculations in `layoutSubviews`. #166

Closed ochococo closed 8 years ago

ochococo commented 8 years ago

Make sure these boxes are checked before submitting your Pull Request - thank you!

[ ] SwiftLint is installed on your system
[ ] The project does not generate any warnings or errors
[ ] The tests are passing
[ ] Branch name is in line with GitFlow

michallaskowski commented 8 years ago

Thanks, I got the same result with my previous approach from here. The problem is in the testMessageBubbleLongText. As you can see there is some extra spacing compared to the manual layout. It is there, because the text in UILabel is clipped, but the height is not adjusted to the lines that fit in the label. This is why I tried content hugging (but got no effect).

ochococo commented 8 years ago

If you're concerned about the details look at the right margin in your approach. One of the "long" is nearly touching the frame of the bubble 😞

ochococo commented 8 years ago

I agree. Up to you really. But fix the right margin.