Bug/weeekends are not ignored in harvest widget

[ncreated]

This PR changes default behavior of Harvest widget. By default, weekends are excluded from "last N" days chart.

To have weekends counted in to the stat, specify it directly in configuration file:

{
  "name": "harvest",
  "settings": {
    ...
    "includeWeekends": false,
    ...
  }
},

Make sure these boxes are checked before submitting your Pull Request - thank you!

• [x] SwiftLint is installed on your system
• [x] The project does not generate any warnings or errors
• [x] The tests are passing
• [x] Branch name is in line with GitFlow

[michallaskowski]

Looks nice, I just don't know how to treat the time billed on weekends. Maybe we should add it to the time billed by a person in the right chart.

Like today I billed 4 hours, and I know I need to do 2,5 hours during the weekend to catch up. And then, in the 'Last 6 days' I should be treated as a guy who billed a standard amount of time. If you agree, then the class BillableDates is still needed, but you need to fetch all the days, and just divide the sum of hours by a number of billable days.

[ncreated]

Looks nice, I just don't know how to treat the time billed on weekends. Maybe we should add it to the time billed by a person in the right chart.

Like today I billed 4 hours, and I know I need to do 2,5 hours during the weekend to catch up. And then, in the 'Last 6 days' I should be treated as a guy who billed a standard amount of time. If you agree, then the class BillableDates is still needed, but you need to fetch all the days, and just divide the sum of hours by a number of billable days

I think we should keep it simple 📏. So we either ignore the weekends or not. With weekends being ignored, all hours billed on Sunday or Saturday get lost. It's a corner case that one works on weekend, and we should not complicate the widget's logic and understanding because of that. WDYT?

[ncreated]

@michallaskowski ⚽ 🍩

[michallaskowski]

I am not sure, it depends what we want to see on the right chart. I am ok with both options (time divided by working days or all days), since both give some valuable info. So it is good for me as it is.

[ncreated]

it depends what we want to see on the right chart.

Yeah, this is the point. Both approaches have value - one shows if the work balance is fine, second if the team delivers desired amount of hours. Sounds like a business decision 😉.

[ncreated]

@michallaskowski ⚽

[michallaskowski]

Looks great