Fix: 'pod lib lint' warning in GCBUtilities.

macoscope / GrandCentralBoard

Hang a TV in your open space or team room to show everyone what's up and get them up to speed.

http://macoscope.com/blog/grand-central-board-for-the-apple-tv/

GNU General Public License v3.0

203 stars 16 forks source link

Fix: 'pod lib lint' warning in GCBUtilities. #185

Closed krris closed 8 years ago

krris commented 8 years ago

This PR fixes warning while running pod lib lint GCBUtilities.podspec.

Make sure these boxes are checked before submitting your Pull Request - thank you!

[ ] SwiftLint is installed on your system
[ ] The project does not generate any warnings or errors
[ ] The tests are passing
[ ] Branch name is in line with GitFlow

michallaskowski commented 8 years ago

It's my bad from previous PR (didn't check podspecs). And there is also a problem with GCBCore.podspec, because it has specified resource_bundles. I am not sure how it should be, because there is also a bundle target created in Pods .pbxproj

krris commented 8 years ago

resource_bundles were removed in https://github.com/macoscope/GrandCentralBoard/pull/183/files. (it's already in develop)

michallaskowski commented 8 years ago

Ok. But shouldn't we add it to GCBUtilities now? I am not sure, cause it is working without it ;) But maybe then we don't need the additional bundle target, and just these lines in podspec file?

michallaskowski commented 8 years ago

Ok, this is addressed in #184