search

macosforge / darwinbuild

Darwinbuild is a collection of tools that assist compilation of the many projects contained in Darwin, the open source base of Apple's macOS operating system.
https://macosforge.github.io/darwinbuild/
Other
128 stars 54 forks source link

Add missing " ". Allow space characters in the directory name $SourceCache #86

Open macosforgebot opened 15 years ago

macosforgebot commented 15 years ago

@LudovicRousseau originally submitted this as ticket:88

Index: darwinbuild/darwinbuild.in
===================================================================
--- darwinbuild/darwinbuild.in  (revision 531)
+++ darwinbuild/darwinbuild.in  (working copy)
@@ -264,7 +264,7 @@ else
    SourceCache="$DARWIN_BUILDROOT/Sources"
 fi

-if [ ! -e $SourceCache ]; then
+if [ ! -e "$SourceCache" ]; then
    mkdir -p "$SourceCache"
 fi
macosforgebot commented 15 years ago

@LudovicRousseau originally submitted this as comment:1:⁠ticket:88

Another patch is also needed

Index: darwinbuild/darwinbuild.in
===================================================================
--- darwinbuild/darwinbuild.in  (revision 531)
+++ darwinbuild/darwinbuild.in  (working copy)
@@ -362,7 +362,7 @@ fi
 ### a cached value.
 ###
 if [ "$build" == "" -a -f "$DARWIN_BUILDROOT/.build/build" ]; then
-   build="$(cat $DARWIN_BUILDROOT/.build/build)"
+   build="$(cat "$DARWIN_BUILDROOT"/.build/build)"
 fi

 ###
macosforgebot commented 14 years ago

@LudovicRousseau originally submitted this as comment:2:⁠ticket:88

This is a duplicate of bug #⁠2 from 2 years ago (but not yet corrected even if the patch is included).